Implement backward case in haskell-forward-sexp #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Regarding the coverage error: shoud I add some tests? |
|
Yes, tests for negative argument are needed. We need both passing and failing tests. |
|
I'm sorry, I don't fully understand the concept of failing tests. Are those test that fail prior to the commit and should be non-failing afterwards? So the test basically describes desirable behaviour, and it is "expected to fail" for stuff that's not implement properly yet? |
|
In this case I mean a case that goes backward-sexp but hits an opening parenthesis. Sorry about confusion. |
gracjan
added a commit
that referenced
this pull request
Feb 16, 2016
Implement backward case in haskell-forward-sexp
|
Nice! Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented the backward case, basically according to your hints in #759. The main difference is that I do not skip back to whitespace, but use plain
backward-sexp, which also properly skips over parens.